Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3765
The features that this PR was going to implement has been resolved by PR
#.
I will close it.
---
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/3765
Hi @haohui @fhueske I am very interested in `DISTINCT`, Let me share some
ideas about this:
First up, in standard database there are two situations can using
`DISTINCT` keyword.
*
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3765
Hi @haohui,
I suggested before that PR #3771 might be used for DISTINCT group window
functions. However, this does not work because we cannot register state for an
AggregateFunction. The
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3765
Updated the PR to codegen the parts used by distinct accumulator. Each
column is calculated independently.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3765
Hi @haohui, thanks for the PR! I like the approach of the wrapping distinct
aggregator.
Unfortunately, this approach won't work with the upcoming changes for the
the UDAGG interface. The
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3765
Note that this PR contains minimal amount of tests. Would love the
feedbacks on what kinds of tests are required here.
---
If your project is set up for it, you can reply to this email and have your
