Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3812
Hi, sorry for the late response here @fanyon.
I've left a comment on the umbrella JIRA on how we proceed with this. Could
you take a look? Thanks :-D
---
If your project is set up for it, you c
Github user fanyon commented on the issue:
https://github.com/apache/flink/pull/3812
@zhangminglei @zentol thanks for your suggestions, and I have updated the
code.
As discussed in
[https://github.com/apache/flink/pull/3750#issuecomment-298869900](url), it may
not need to r
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3812
There is no doubt that you **can** modify the commits of an open PR. My
point is that you **shouldn't** because it messes with the review.
This applies to both squashing commits and force push
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3812
@zentol Sorry. I just drunk. My mean is we can use ```git rebase -i
origin/master``` to combine lots of commit logs into one log and then use
```git push origin -f branch_issueId``` push to orgi
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3812
@zhangminglei I don't understand what you're trying to say.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3812
```git push upstream -f xxx ``` DOES NOT WORK for squashed it ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3812
For clarification: Commits should **not** be squashed once the PR has been
opened. However, *before* opening a PR it would be good to squash these minor
commits.
---
If your project is set up for it
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3812
@fanyon Another suggestion here. Make the lots of commit log into one log
is nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
