[GitHub] flink issue #3923: [FLINK-6587] [table] Simplification and bug fixing of the...

2017-05-17 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3923 Thanks @fhueske. I will merge this and update the documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] flink issue #3923: [FLINK-6587] [table] Simplification and bug fixing of the...

2017-05-16 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3923 The PR looks good to me. +1 from my side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] flink issue #3923: [FLINK-6587] [table] Simplification and bug fixing of the...

2017-05-16 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3923 @shaoxuan-wang the function catalog is case insensitive anyway. With this PR we have almost no keywords anymore. So a "sum" could be overwritten by "SUM". --- If your project is set up for it, you c

[GitHub] flink issue #3923: [FLINK-6587] [table] Simplification and bug fixing of the...

2017-05-16 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3923 @twalthr, it seems we have reserved the keyword with the case insensitive. For instance, we cannot use "Sum" and "SUM", as "sum" is reserved. Did we intent to filter the keyword like this? --