[GitHub] flink issue #3961: [FLINK-6656] [cep] Change element PriorityQueue to MapSta...

Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3961 @kl0u asked me to merge this PR to the release-1.3 branch. It seems the change is good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] flink issue #3961: [FLINK-6656] [cep] Change element PriorityQueue to MapSta...

Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/3961 Thanks for clarification! Z pozdrowieniami! / Cheers! Dawid Wysakowicz *Data/Software Engineer* Skype: dawid_wys | Twitter: @OneMoreCoder

[GitHub] flink issue #3961: [FLINK-6656] [cep] Change element PriorityQueue to MapSta...

Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3961 Hi @dawidwys ! Your understanding is correct in the sense that it does not leverage to the fullest the fact of keys being returned in order. The reason is that this is valid only in RocksDB state backen

[GitHub] flink issue #3961: [FLINK-6656] [cep] Change element PriorityQueue to MapSta...

Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/3961 Just a question from my side to understand this change better. Does it really leverage the fact of keys being returned in order? To evaluate `getSortedTimestamps` you need to iterate whole keySet an

[GitHub] flink issue #3961: [FLINK-6656] [cep] Change element PriorityQueue to MapSta...

Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3961 The re-ordering is just to verify that at watermark time, we actually order by event-time. On May 22, 2017 2:57 PM, "Aljoscha Krettek" wrote: > This looks good! Why is the eleme

[GitHub] flink issue #3961: [FLINK-6656] [cep] Change element PriorityQueue to MapSta...

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3961 This looks good! Why is the element processing reordered in places in the tests, though? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we