[GitHub] flink issue #4470: [FLINK-7343] Simulate network failures in kafka at-least-...

2017-08-08 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4470 Thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #4470: [FLINK-7343] Simulate network failures in kafka at-least-...

2017-08-08 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4470 Please close the commit and the Jira issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #4470: [FLINK-7343] Simulate network failures in kafka at-least-...

2017-08-07 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4470 Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] flink issue #4470: [FLINK-7343] Simulate network failures in kafka at-least-...

2017-08-07 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4470 Yes I also didn't like adding this new flag, but didn't have enough motivation to change it. I have done some refactoring extracting those dynamically set in `prepare` method to some `Config`