[GitHub] flink issue #4484: [FLINK-7376][Client] Cleanup options class and test class...

2017-08-07 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4484 Yes! I hope I didn't discourage you from contributing. It's just that lately we have become careful with purely cosmetic changes because they can introduce subtle bugs and cause overhead when

[GitHub] flink issue #4484: [FLINK-7376][Client] Cleanup options class and test class...

2017-08-07 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4484 Thank you for your reply.@aljoscha I am sorry for my first PR. I think I need to read this [Contributing Code](http://flink.apache.org/contribute-code.html). --- If your project is set up for

[GitHub] flink issue #4484: [FLINK-7376][Client] Cleanup options class and test class...

2017-08-07 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4484 Hi @yew1eb, I'm afraid we should not merge this PR. While I do realise that keeping the code clean is good, I don't think we should just change some parts of the code only to make them look