[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

2017-08-17 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4535 @zhuganghuaonnet please also rebase this pull request (there are conflicting classes) and change the pull request title. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

2017-08-17 Thread zhuganghuaonnet
Github user zhuganghuaonnet commented on the issue: https://github.com/apache/flink/pull/4535 @Tzu-Li Tai I have created a jira https://issues.apache.org/jira/browse/FLINK-7474. Pls help to review. Thx. :)

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

2017-08-15 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4535 @zhuganghuaonnet please let me know when you've opened the JIRA, and rebased this pull request onto the latest `master`. Also please remember to rename the pull request title (you can take a look

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

2017-08-15 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4535 @greghogan yes, a separate `flink-connectors` idea has always been a possible approach in the community, but AFAIK we haven't fully committed to it yet. I can continue to shepherd this contribution

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

2017-08-15 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4535 @tzulitai this does sound like a good candidate for inclusion in Flink. Perhaps a separate `flink-connectors` repo would work better than Apache Bahir. --- If your project is set up for it, you

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

2017-08-15 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4535 @greghogan I don't think there's actually a consensus that all new connectors should strictly go to Apache Bahir. It still depends case by case, and brought to discussion in the mailing lists if

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

2017-08-14 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4535 @zhuganghuaonnet we should also mention that new connectors are being contributed through the Flink release of [Apache Bahir](http://bahir.apache.org). --- If your project is set up for it, you

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

2017-08-14 Thread zhuganghuaonnet
Github user zhuganghuaonnet commented on the issue: https://github.com/apache/flink/pull/4535 Hi Tai, I cannot find JIRA related to Azure eventhubs. I will create one later, fill pull request template and send another pull request. Thx. Regards Joe

[GitHub] flink issue #4535: Eventhubs-support read from and write to Azure eventhubs

2017-08-14 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4535 Hi @zhuganghuaonnet, thanks a lot for this contribution! However, taking a step back, is there a JIRA ticket for this contribution? If not, please make sure that one is opened for it first.