Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4552
looks good - Let's start some cluster tests and then we're ready to merge
---
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4552
1. Thanks for you FLINK08425.
2. I would have thought the tests for
`ResultSubpartition#nextBufferIsEvent` which have already been covered before.
The test for `BufferAndBacklog#nextBufferIsEve
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4552
@NicoK , I have submitted the switch for keeping the old mode and the new
credit-based mode.
---
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4552
@NicoK , thanks for your reviews!
I have submitted all the patches you provided offline to address above
issues.
1. Remove `FLINK-8425` from this PR.
2. Do you think I should add m
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4552
one thing which we talked about offline: as a precaution, we should keep
the old implementation around and allow the users to basically turn the
credit-based flow control algorithm on/off (the accounti
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4552
@NicoK , I have submitted all the modifications based on the patches you
provided.
The tests for `nextBufferIsEvent` will be added in a new commit tomorrow.
---
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4552
@NicoK , I have rebased the latest codes. Wish your reviews!
---
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4552
Yes, I am planing to rebase this with the latest changes of previous
commits.
---
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4552
Ok, I think, I'll manage the review without the split.
Since this is the last of the credit-based PRs though, can you rebase on
top of the latest changes (preferably after addressing the commen
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4552
@NicoK , thanks for focusing on the last PR.
I am supposed to divide this into two separate ones as you said. But I am
afraid some current tests may fail if I only modify and enable the cre
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4552
@pnowojski , this PR is ready for review.
It covers almost all the logics of credit-based on sender side.
In addition, I replace the current `PartitionRequestClientHandler` with
`Credi
11 matches
Mail list logo
