Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4554
Yes, I created an alternative PR for that:
https://github.com/apache/flink/pull/4564
My only worry is that all the tests in that PR would also pass with the
other child-first class loader
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4554
I think what you mentioned is one more reason to not use this in too many
places for now, but only inside the TaskManager / Tasks. Let's introduce that
as a tool that users can use to resolve
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4554
Probably, yes. I also don't know what other stuff this could break, though.
For example, I don't know if queryable state, which starts netty (and Akka)
stuff will still work with this.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4554
Ah, I see - that is probably related to reading resources from a jar file
(like the config), methods like `getResourceAsStream()`.
I can see that the "delegate to parent after child" lookup
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4554
This is the exception I got with the class loader from
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4554
The system class loader stuff was leftover from an earlier version, I
didn't mean to have that in there.
In the first version I copied the `ChildFirstClassLoader` from
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4554
I took only a very brief look at this, but I am not totally sure whether
the `ChildFirstClassLoader` implementation is actually correct. Even if it is,
it seems to do redundant work, like
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4554
@StephanEwen Could you please have a look since this `ClassLoader` business
is quite important to get right.
---
If your project is set up for it, you can reply to this email and have your
reply
