[GitHub] flink issue #4557: [hotifx][streaming] Simplify state of TwoPhaseCommitSinkF...

2017-08-23 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4557 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #4557: [hotifx][streaming] Simplify state of TwoPhaseCommitSinkF...

2017-08-23 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4557 Merged 👌 Could you please close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #4557: [hotifx][streaming] Simplify state of TwoPhaseCommitSinkF...

2017-08-17 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4557 Ok, I will create JIRA issues for such things in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #4557: [hotifx][streaming] Simplify state of TwoPhaseCommitSinkF...

2017-08-17 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4557 This LGTM, +1. Merging this .. Minor nitpick for the future: I think although this is a small fix, the nature of the fix still deserves a dedicated JIRA ticket for it. Hotfixes, AFAIK,