[GitHub] flink issue #4574: [FLINK-6864] Fix confusing "invalid POJO type" messages f...

2017-11-28 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4574 @zjureel am merging this ... thanks for the PR and edits! ---

[GitHub] flink issue #4574: [FLINK-6864] Fix confusing "invalid POJO type" messages f...

2017-08-30 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4574 @ggevay @greghogan Thank you for your suggestions, I tried to add some notice about performance loss in the log, what do you think? Thanks --- If your project is set up for it, you can reply to this

[GitHub] flink issue #4574: [FLINK-6864] Fix confusing "invalid POJO type" messages f...

2017-08-30 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4574 I also agree that these messages have been personally useful. I think this PR is an improvement but that we could do better to note and/or emphasize the performance implications of `GenericType`. I

[GitHub] flink issue #4574: [FLINK-6864] Fix confusing "invalid POJO type" messages f...

2017-08-23 Thread ggevay
Github user ggevay commented on the issue: https://github.com/apache/flink/pull/4574 I agree with @zjureel . Even though I know the POJO rules well, it still happened to me more than once that I accidentally had a non-POJO, and I only noticed this because of these log messages, so I t

[GitHub] flink issue #4574: [FLINK-6864] Fix confusing "invalid POJO type" messages f...

2017-08-22 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4574 @tzulitai I create this PR to fix [https://issues.apache.org/jira/browse/FLINK-6864](https://issues.apache.org/jira/browse/FLINK-6864), I think add logs instead of removing them will be better, what