Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4647
The next time we touch `MutableIOMetrics`, we should also refactor
`MutableIOMetrics#addIOMetrics` such that one passes an IOMetrics object into
it instead of the `MetricFetcher`.
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4647
Sorry for joining the party so late, but I think the solution is
incomplete. Flink displays many metrics for the different components of the
system. For example, the `TaskManagersHandler` displa
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4647
merging.
---
Github user jameslafa commented on the issue:
https://github.com/apache/flink/pull/4647
@zentol I agree, it make it a lot easier to read. I just pushed the update.
Thanks for your feedback.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4647
Tried it out and it works as expected.
After looking at the aggregation code in detail I suggest to set an
isComplete boolean for each counter instead of setting the value to -1. This
makes t
Github user jameslafa commented on the issue:
https://github.com/apache/flink/pull/4647
@zentol I pushed the changes we talk about yesterday. Let me know if it's
fine for you :)
Thanks for your help.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4647
@uce The checkstyle didn't catch it since the `runtime/executiongraph`
package isn't covered by checkstyle.
The flag will not fulfill the intended purpose after #4472 since the
fetched metric
Github user uce commented on the issue:
https://github.com/apache/flink/pull/4647
Thanks @zentol for the review.
@jameslafa
- Regarding the first point with checkstyle: It's confusing that our
checkstyle settings don't catch this, but Chesnay is right here. Seems nitpicky
