Github user hequn8128 commented on the issue:
https://github.com/apache/flink/pull/4674
@fhueske Hi, I will close it. Thanks for the checking.
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4674
Hi @hequn8128, @wuchong. What are your plans for this PR.
Should we get it in or are you OK to close it?
Thanks, Fabian
---
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4674
I'm +1 with the first option, i.e. declare the element field as
`transient`. You are right, the `SingleElementIterable` is not necessary to be
serialized.
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4674
Thanks for the info @hequn8128! As I said before, I don't mind making
`SingleElementIterable` `Serializable`. However, we have to ensure that the
property also holds. `element: T` is not necessarily
Github user hequn8128 commented on the issue:
https://github.com/apache/flink/pull/4674
hi, @fhueske
I was using sliding window and `NotSerializableException` was thrown when
doing incremental snapshot. This can be fixed by implementing
`SingleElementIterable` with `Serializable
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4674
Hi @hequn8128, can you give some information on the motivation for this PR?
Thanks, Fabian
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4674
Hi @hequn8128, thanks for the PR.
I think it's OK to make the iterable serializable, but would like to
understand better when a non-serializable iterable leads to a bug.
Thanks, Fabian
