[GitHub] flink issue #4700: [FLINK-7649] [flip6] Extend JobTerminationHandler to supp...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4700 Thanks for the review @zentol. You are right, that I should rather add a new JobTerminationHandler subsuming the functionality of the `JobCancellationHandler` and the `JobStoppingHandler`. Will

[GitHub] flink issue #4700: [FLINK-7649] [flip6] Extend JobTerminationHandler to supp...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4700 I've reverted the changes to the `JobCancellationHandler` and instead created a new `JobTerminationHandler` directly extending `AbstractRestHandler`. ---

[GitHub] flink issue #4700: [FLINK-7649] [flip6] Extend JobTerminationHandler to supp...

2017-09-27 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4700 +1, feel free to merge once we concluded our discussions in #4697 :) ---

[GitHub] flink issue #4700: [FLINK-7649] [flip6] Extend JobTerminationHandler to supp...

2017-09-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4700 Thanks for the review @zentol. Rebasing onto the latest #4697 version. ---