Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4728
Thanks for your review @zentol and @tzulitai. Merging this PR.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4728
+1 from my side too.
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4728
Thanks for addressing / replying to my comments.
LGTM, +1 from me
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4728
I've rebased the code onto the latest master. Are all PR comments resolved
@zentol and @tzulitai?
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4728
Thanks for the review @zentol and @tzulitai.
@zentol yes you are right. The Flip-6 `JobMaster` will only return the
`ArchivedExecutionGraph`. I intend to set the `timeToLive` for the
`E
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4728
But that's not the case for the flip-6 code, is it? There the JobMaster
creates a separate ArchivedExecutionGraph that is not automatically updated.
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4728
Thanks for the review @zentol. I've addressed your comments.
Since the `WebRuntimeMonitor` requests the actual `ExecutionGraph` from the
`JobManagerGateway` instead of the `ArchivedExecu
