[GitHub] flink issue #4935: [Flink-7945][Metrics&connector]Fix per partition-lag metr...

2017-11-30 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/4935 Hi, @tzulitai After i read kafkaConsumer code again, i found that the per partition kafka lag metric is register in method `FetchManagerMetrics#recordPartitionLag` But the when the client get the

[GitHub] flink issue #4935: [Flink-7945][Metrics&connector]Fix per partition-lag metr...

2017-11-28 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4935 Hi @Aitozi, sorry for the long delay in relaying back to this PR. I'm still not convinced that this is a sane solution. For example, what is a "good" setting for the `KEY_REGISTER_TIMES` pro

[GitHub] flink issue #4935: [Flink-7945][Metrics&connector]Fix per partition-lag metr...

2017-11-27 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/4935 ping @tzulitai ~ ---

[GitHub] flink issue #4935: [Flink-7945][Metrics&connector]Fix per partition-lag metr...

2017-11-07 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/4935 Hi @tzulitai , could you take look at this again :-) ? ---

[GitHub] flink issue #4935: [Flink-7945][Metrics&connector]Fix per partition-lag metr...

2017-11-03 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/4935 update the code according to the comment. ping @tzulitai ---

[GitHub] flink issue #4935: [Flink-7945][Metrics&connector]Fix per partition-lag metr...

2017-11-01 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4935 One other side note: Please squash your commits into a single one, with an appropriate commit message (you can refer to the other commits in the codebase as a starter). `[FLINK-7945][Met

[GitHub] flink issue #4935: [Flink-7945][Metrics&connector]Fix per partition-lag metr...

2017-11-01 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/4935 cc @zentol @tzulitai please help review the code. ---