Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4968
merging.
---
Github user elbaulp commented on the issue:
https://github.com/apache/flink/pull/4968
Hi, Do I need to do something more in order to this PR be merged?
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4968
LGTM
+1 to merge
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4968
+1
---
Github user elbaulp commented on the issue:
https://github.com/apache/flink/pull/4968
@greghogan Oh, of course, didn''t saw it, how many $pids! Done.
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4968
@elbaulp au contraire, thank you for fixing this bug. Do we need quotes for
the following?
line 69: pid=$FLINK_PID_DIR/flink-$FLINK_IDENT_STRING-$DAEMON.pid
line 181: done < ${pid}.tmp
Github user elbaulp commented on the issue:
https://github.com/apache/flink/pull/4968
@greghogan Done, sorry for ignoring the stop script.
---
Github user elbaulp commented on the issue:
https://github.com/apache/flink/pull/4968
@greghogan Didn't realized!, its failing too. I am going to fix it.
---
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4968
Do we also need to quote within sub-expressions? Have you looked at the
stop script?
---
