Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5102
merging.
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5102
LGTM.
+1 to merge this now, and we think about removing the source as well as
reworking the doc example to not use it (I think it might be nice to directly
kick off the docs with an intro e
Github user uce commented on the issue:
https://github.com/apache/flink/pull/5102
I would be in favour of removing this or moving it to Bahir, but it is
currently used in a [doc
example](https://ci.apache.org/projects/flink/flink-docs-release-1.4/quickstart/run_example_quickstart.html
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5102
The changes look good! But you comment about needing that IRC channel seem
valid. If we don't have the test, however, we would have no way of knowing that
the code at least works. (We could also dro