Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5112
@StephanEwen let me know if this is good to go
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5112
@StephanEwen @greghogan ok, so looks like the rules of checkstype and
scalastyle are a bit different, that's why I misreported
`flink-streaming-scala`'s style checking is inactive.
scala s
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5112
@bowenli86 Checkstyle is Java-only. There is a
[Scalastyle](http://www.scalastyle.org).
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5112
@StephanEwen Thanks Stephan. To your comments:
1. in order to have `experiemental/scala` package in
`flink-streaming-scala`, I have to make `DataStreamUtils` its own class to
avoid package
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5112
@StephanEwen @tillrohrmann let me know if you have more concerns
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5112
@StephanEwen let me know if you have more concerns
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5112
@StephanEwen That's a great idea to have an `/experimental` package for
such things. Will update the PR
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5112
I would actually be in favor of dismantling the `flink-streaming-contrib`
project.
We could have a dedicated package `experimental` in `flink-streaming-java`
for such code. The package s
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5112
@tillrohrmann I agree that `CollectSink` seems to be immature after taking
another detailed look at it.
I've sent an email to dev alias on Dec 2. Can you please respond to it and
start a
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5112
Thanks for your contribution @bowenli86. I think we should reach first some
kind of consensus on the ML before moving the classes. I'm actually not sure
whether `CollectSink` is something we sho
10 matches
Mail list logo
