[GitHub] flink issue #5120: [FLINK-8186] Exclude flink-avro from flink-dist; fix Avro...

2017-12-06 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5120 thanks for reminding me! closing... ---

[GitHub] flink issue #5120: [FLINK-8186] Exclude flink-avro from flink-dist; fix Avro...

2017-12-06 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5120 @aljoscha Did you forget to close this PR? ---

[GitHub] flink issue #5120: [FLINK-8186] Exclude flink-avro from flink-dist; fix Avro...

2017-12-04 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5120 @zentol I think so, yes. First, I only excluded, which led me to discover the problem with `AvroUtils` and them not using the right classloader to dynamically load the them. ---

[GitHub] flink issue #5120: [FLINK-8186] Exclude flink-avro from flink-dist; fix Avro...

2017-12-04 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5120 Looks good to me. This is actually two fixes in one: 1. Avro should not be in `flink-dist`, because starting with `org.apache.flink`, it would always be loaded *"parent first"*. That

[GitHub] flink issue #5120: [FLINK-8186] Exclude flink-avro from flink-dist; fix Avro...

2017-12-04 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5120 is the exclusion from flink-dist still necessary? ---