[GitHub] flink issue #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supported

2018-01-20 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5241 Thanks for the update and rebasing @sunjincheng121. The PR looks good. Will run final tests and merge it. Best, Fabian ---

[GitHub] flink issue #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supported

2018-01-20 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/5241 Thanks @fhueske, I had rebase the code. I appreciate if you can review the changes. Best, Jincheng ---

[GitHub] flink issue #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supported

2018-01-19 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5241 Please rebase the PR on the master once #5320 was merged. I'll have a look at the changes after the rebase. Thank you, Fabian ---

[GitHub] flink issue #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supported

2018-01-15 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/5241 @fhueske Thanks for your review and suggestion about FLINK-8355, I have fixed the FLINK-8355 issue in this PR. I appreciate if you can review the change again. Best, Jincheng ---