[GitHub] flink issue #5317: [FLINK-8458] Add the switch for keeping both the old mode...

2018-02-22 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/5317 @pnowojski , thanks for your messages and I already updated the commit as you suggested. ---

[GitHub] flink issue #5317: [FLINK-8458] Add the switch for keeping both the old mode...

2018-02-22 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/5317 @zhijiangW I think that configuration description should come from `/flink/docs/_includes/generated/netty_configuration.html`. @zentol has changed something recently and it seems that config descri

[GitHub] flink issue #5317: [FLINK-8458] Add the switch for keeping both the old mode...

2018-02-20 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/5317 @NicoK , I found most of the codes in this PR are already merged into master by commit `0093bcbe771f296baf3857ef15fe7ec9b22bbc34` in your `FLINK-8425`. Maybe I only need to add the `config.md` in t

[GitHub] flink issue #5317: [FLINK-8458] Add the switch for keeping both the old mode...

2018-02-20 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/5317 Yes, I also found that and was rebasing on the latest codes. Because I am on the Spring Festival vacation, it can be ready later today or on Thursday. ---

[GitHub] flink issue #5317: [FLINK-8458] Add the switch for keeping both the old mode...

2018-02-20 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5317 @zhijiangW can you rebase the new changes? The previous implementation got merged and from the comments I see here, there might have been some changes since then which should be applied as well. ---