[GitHub] flink issue #5376: [FLINK-6214] WindowAssigners do not allow negative offset...

2018-03-09 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5376 Ah, one problem: What happens if the offset is larger (by absolute value) than the window length? Then the offset would still be negative with this change. ---

[GitHub] flink issue #5376: [FLINK-6214] WindowAssigners do not allow negative offset...

2018-03-09 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5376 If we decide that we want to support negative offsets, this looks like a good implementation. @aljoscha what is your take, should we support negative offsets? ---