[GitHub] flink issue #5530: [FLINK-8660] Enable the user to provide custom HAServices...

2018-03-09 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5530 I think this looks quite good now. Since 1.5 feature freeze is over for a bit, would suggest to merge this into master (1.6-SNAPSHOT). Looking at the code (this PR and the high a

[GitHub] flink issue #5530: [FLINK-8660] Enable the user to provide custom HAServices...

2018-02-24 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5530 You could rebase on the latest master and force push to retrigger the build. ---

[GitHub] flink issue #5530: [FLINK-8660] Enable the user to provide custom HAServices...

2018-02-24 Thread kbialek
Github user kbialek commented on the issue: https://github.com/apache/flink/pull/5530 Looks like build process was terminated by kernel. Can someone retrigger it? ---

[GitHub] flink issue #5530: [FLINK-8660] Enable the user to provide custom HAServices...

2018-02-24 Thread kbialek
Github user kbialek commented on the issue: https://github.com/apache/flink/pull/5530 Now uses high-availability configuration property can be set either to none, zookeeper or FQN of factory class ---

[GitHub] flink issue #5530: [FLINK-8660] Enable the user to provide custom HAServices...

2018-02-20 Thread kbialek
Github user kbialek commented on the issue: https://github.com/apache/flink/pull/5530 Closing without merge, because of: 1. Test failure 2. I'd like to implement Stephan's idea ---

[GitHub] flink issue #5530: [FLINK-8660] Enable the user to provide custom HAServices...

2018-02-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5530 I think this is a nice approach. I would suggest to not split the config options between `high-availability` and factory that is only used in *CUSTOM* mode, but use the `high-availability