Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5552
Thanks for the reviews, y'all. ð
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5552
@aljoscha Yes.
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5552
@kl0u thanks for the review! I saw that the Scala ITCase is very different
from the Java one. I (or someone) should probably tackle that in a follow-up.
WDYT?
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5552
looks good to me
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5552
I added some new commits that unify the test to have only one method for
performing and verifying the savepoint. I didn't go for the factory approach in
the end because I think that would have made
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5552
I will have a look at the current state of the PR, but given that you
started the effort, it would be good for completeness, to also refactor the
`scala` equivalent `ITcase` to get rid of all the
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5552
The sister PR for `release-1.4` is #5553 .
---
