[GitHub] flink issue #5691: [FLINK-8802] [QS] Fix concurrent access to non-duplicated...

2018-03-14 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5691 Thanks for the review @zentol ! I updated the PR integrating your comments, or commenting on why I did not do it. Please have a look and let me know if you have more comments. ---

[GitHub] flink issue #5691: [FLINK-8802] [QS] Fix concurrent access to non-duplicated...

2018-03-14 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5691 @StefanRRichter and @zentol I will ping you when I am done with the refactoring. ---

[GitHub] flink issue #5691: [FLINK-8802] [QS] Fix concurrent access to non-duplicated...

2018-03-15 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5691 This is ready for another review @StefanRRichter and @zentol ---

[GitHub] flink issue #5691: [FLINK-8802] [QS] Fix concurrent access to non-duplicated...

2018-03-19 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5691 That is because cleaning up the cache is happening from another thread, other than the one accessing the serializers, and ThreadLocal does not have a clear() method that you can call from anoth

[GitHub] flink issue #5691: [FLINK-8802] [QS] Fix concurrent access to non-duplicated...

2018-03-23 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5691 Can someone have a look at this? ---