[GitHub] flink issue #5705: [FLINK-8968][state]Fix native resource leak caused by Rea...

2018-03-21 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5705 Hi @tillrohrmann could you please have a look at this? This PR covers multi bugs that should be addressed...I think maybe stefan is too busy with the testing works on 1.5 currently... ---

[GitHub] flink issue #5705: [FLINK-8968][state]Fix native resource leak caused by Rea...

2018-03-18 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5705 I made a fixup for some additional minor bug in `RocksDBStateBackendConfigTest.java`. ---

[GitHub] flink issue #5705: [FLINK-8968][state]Fix native resource leak caused by Rea...

2018-03-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5705 @StefanRRichter I have updated the code, could you please have a look... ---

[GitHub] flink issue #5705: [FLINK-8968][state]Fix native resource leak caused by Rea...

2018-03-16 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5705 You can cover it here and I will review it again 👍 ---

[GitHub] flink issue #5705: [FLINK-8968][state]Fix native resource leak caused by Rea...

2018-03-16 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5705 @StefanRRichter Sorry for pinging you again in this PR, but I found there maybe be another issue for `full checkpoint`. It's about the `kvStateInformation`, we should create a deep copy of `kvState

[GitHub] flink issue #5705: [FLINK-8968][state]Fix native resource leak caused by Rea...

2018-03-15 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5705 LGTM 👍 ---

[GitHub] flink issue #5705: [FLINK-8968][state]Fix native resource leak caused by Rea...

2018-03-15 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5705 @StefanRRichter Could you please have a look at this? ---