[GitHub] flink issue #5811: [FLINK-9113] [connectors] Fix flushing behavior of bucket...

2018-04-06 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5811 I will close this PR for now. Because it could not solve the general issue mentioned in HADOOP-7844. ---

[GitHub] flink issue #5811: [FLINK-9113] [connectors] Fix flushing behavior of bucket...

2018-04-06 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5811 Thanks for looking into it @kl0u. I observed the same behavior during debugging. I will remove the check for now and open a follow up issue. If there is no better solution, we might need to close

[GitHub] flink issue #5811: [FLINK-9113] [connectors] Fix flushing behavior of bucket...

2018-04-06 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5811 Well it seems like for these tests, the `flush` is not actually flushing. The files are there, the `validPartLength` is correct (=6 as we just write `test1\n`) but the data is not actually on disk. If

[GitHub] flink issue #5811: [FLINK-9113] [connectors] Fix flushing behavior of bucket...

2018-04-04 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5811 @kl0u do you have an idea why `BucketingSinkTest` is failing? It seems that the written data parts are always empty. ---