Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5879
@dawidwys It's ok with me, the unrelated change should be a minor java doc
hot fix.
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/5879
Thanks @sihuazhou for the contribution. LGTM for me though I would remove
the unrelated change if it is ok with you.
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5879
Could anyone have a look at this? A minor change that would only effects
the log...absolutely won't cause any regression problem, but would be helpful
when user diagnosing the job according to the
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5879
@tillrohrmann I updated the PR, could you please have a look again?
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5879
@tillrohrmann I think would be enough to simply print the exception message
in the log, if we will refactor the PRC as a second step. Will update the PR.
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5879
@sihuazhou I'm actually no longer sure whether sending exceptions as causes
along with the RPC messages was the best decision. Exceptions signal an
exceptional situation and should not occur in
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5879
Hi @tillrohrmann , thanks for your reply, @zentol proposed to introduce a
`normal-life-cycle exception` in his previous review, the `normal-left-cycle
exception` would only log the exception messag
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5879
Thanks for the contribution @sihuazhou. You're right that the log output of
the `SlotPool` component is a bit too noisy and should not log the full stack
trace in the happy case. What about not
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5879
cc @StephanEwen
---
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5879
cc @tillrohrmann
---
10 matches
Mail list logo
