[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...

2018-05-13 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5897 Agreed, let's add it to master as well... ---

[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...

2018-05-13 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5897 Thanks, @StephanEwen. I will later merge this for `release-1.4` and `release-1.5`. Should we merge it for `master` as well and create a JIRA to drop the deprecated code? That would ensure w

[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...

2018-05-13 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5897 From my side, +1 to merge this to `release-1.4` and `release-1.5`. ---

[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...

2018-05-13 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5897 Forwarding some comment from @fhueske from JIRA: > I tried to reproduce this issue for 1.5 but it seems to work. > > Flink 1.5 should be out soon (release candidate 2 was publishe

[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...

2018-05-12 Thread tragicjun
Github user tragicjun commented on the issue: https://github.com/apache/flink/pull/5897 any progress on this? ---

[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...

2018-05-12 Thread tragicjun
Github user tragicjun commented on the issue: https://github.com/apache/flink/pull/5897 encountered the same issue, any progress on this? ---

[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...

2018-05-10 Thread nezhazheng
Github user nezhazheng commented on the issue: https://github.com/apache/flink/pull/5897 encountered same issue. ---

[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...

2018-04-30 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5897 Can we actually get rid of `commons-configuration` in the table API? All the commons packages with their weird long tail of not properly declared dependencies have become a bit of an anti

[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...

2018-04-24 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5897 The Flink code doesn't need the `jcl` dependency but if `commons` libraries want to log something we should make this possible, right? Good point @zentol. I will verify the logs again. ---

[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...

2018-04-23 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5897 @zentol @EronWright would be great if you could verify my changes ---