[GitHub] flink issue #5923: [FLINK-9253][network] make the maximum floating buffers c...

2018-05-07 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5923 Apparently, there's a problem with unknown input channels that surfaced with the newly-merged extra tests: they don't get exclusive buffers (naturally) but the floating buffers are calculated and

[GitHub] flink issue #5923: [FLINK-9253][network] make the maximum floating buffers c...

2018-05-07 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5923 Honestly, I did not find the proposed change too convincing either due to the additional branch into bounded vs. unbounded partitions which caused the variable names to be wrong in the unbounded case.

[GitHub] flink issue #5923: [FLINK-9253][network] make the maximum floating buffers c...

2018-04-27 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/5923 Thanks for improving it, looks good from my point. :) ---