Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5955
@kl0u yes, lets do that as a separate commit then.
+1, this looks good to me.
One final comment for the merge:
When merging to `master`, we should have test savepoints for both `
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5955
Hi @tzulitai ! Thanks for the review. I integrated most of your comments.
The only one I left out is the one about merging the checkpointing and the
checking. I am not against that. It is just that the
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5955
Could you review it @tzulitai ?
---
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5955
Could you review it @aljoscha ?
---