[GitHub] flink issue #5955: [FLINK-8659] Add migration itcases for broadcast state.

2018-05-17 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5955 @kl0u yes, lets do that as a separate commit then. +1, this looks good to me. One final comment for the merge: When merging to `master`, we should have test savepoints for both `

[GitHub] flink issue #5955: [FLINK-8659] Add migration itcases for broadcast state.

2018-05-16 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5955 Hi @tzulitai ! Thanks for the review. I integrated most of your comments. The only one I left out is the one about merging the checkpointing and the checking. I am not against that. It is just that the

[GitHub] flink issue #5955: [FLINK-8659] Add migration itcases for broadcast state.

2018-05-14 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5955 Could you review it @tzulitai ? ---

[GitHub] flink issue #5955: [FLINK-8659] Add migration itcases for broadcast state.

2018-05-08 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5955 Could you review it @aljoscha ? ---