Github user cricket007 commented on the issue:
https://github.com/apache/flink/pull/5995
What about implementing a `KeyedDeserializationSchema` for Avro?
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5995
Looks good, thanks!
+1 to merge this
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/5995
I've addressed your comments @StephanEwen . If you don't have any more, I
will merge it today.
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5995
Added a few more comment, most importantly around exception wrapping.
Otherwise, looking good...
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/5995
@StephanEwen could you have another look?
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5995
I would actually keep the package name for now. It makes sense, because the
connection to the registry is avro-specific at the moment...
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/5995
Also as for the package name or place where to put it, I don't feel
competent to suggest a place, therefore will be happy to apply your suggestion.
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/5995
As for the snapshot binary data, I do understand that it should be created
with appropriate flink version (in this case in theory with flink 1.3) and I've
tried really hard to do so until I found ou
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/5995
Right sorry for that. I've changed the data generator a bit, so it produced
different results than before with the same seed. I've recreated the serialized
data with updated `TestDataGenerator`. It
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5995
Thanks, the main code looks good!
Unfortunately, this seems to wither break the compatibility with prior
savepoints (when Avro types were implicitly handled through Kryo, now bridged
thr
10 matches
Mail list logo
