Github user fmthoma commented on the issue:
https://github.com/apache/flink/pull/6021
Merged manually by squashing: 7d034d4
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/6021
@fmthoma I've merged this manually. Thanks for the contribution.
Could you close this PR?
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/6021
Thanks @fmthoma, will proceed to merge this ..
---
Github user fmthoma commented on the issue:
https://github.com/apache/flink/pull/6021
@tzulitai Thanks for your last review comments! I addressed them, and
rebased the branch against master.
---
Github user fmthoma commented on the issue:
https://github.com/apache/flink/pull/6021
@tzulitai @bowenli86 I've made some more changes while investigating
awslabs/amazon-kinesis-producer#183:
* I've followed your suggestion and used `wait()` instead of
`Thread.sleep()`, see `
Github user fmthoma commented on the issue:
https://github.com/apache/flink/pull/6021
@tzulitai I added some docs.
As for the `flush()` vs. just waiting: As I see it, the
[`RecordMaxBufferedTime`](https://github.com/awslabs/amazon-kinesis-producer/blob/ce77505306c104a6016b0c08
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/6021
@fmthoma yes, that would be great.
---
Github user fmthoma commented on the issue:
https://github.com/apache/flink/pull/6021
@tzulitai I believe the right location is `docs/dev/connectors/kinesis.md`?
I'll add some docs there.
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/6021
@fmthoma I think this might benefit from an actual documentation, not only
Javadocs.
---
Github user fmthoma commented on the issue:
https://github.com/apache/flink/pull/6021
@tzulitai I agree on adding additional docs, where do you suggest I should
put them? In the Javadoc on `setQueueLimit()`?
My current suggestion is to look at the size of your individual recor
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/6021
@tzulitai adding docs to educate users on tuning KPL performance would be
good. I has quite some experience on it (as you may have know :) Ping me if
you start working on it before I do, and I'll
11 matches
Mail list logo
