Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6082
In the end it seems that I had to rewrite this whole Avro logic in order to
finally support all types and both specific and generic Avro records. I hope it
is ok that I could not include your
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
@twalthr Sure, please go ahead and let me know if anything I can help
further.
---
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6082
Thanks for the update @tragicjun. I had a look at the changes. I think the
logic does still not cover all cases that we want to cover. Avro has the
following types:
`RECORD, ENUM, ARRAY, MAP,
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
@suez1224 @twalthr any update please?
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
The latest commit uses **Types.OBJECT_ARRAY** to map Avro array type.
Hence, Avro **GenericData.Array** has to be converted into regular java arrays
back (see **AvroRowSerializationSchema**) and
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
@fhueske Great, let me take a look and commit another version later.
---
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6082
I think we have to return an typed array here. A `List` won't be supported
by the built-in SQL functions.
There are a few tricks on can play to create typed arrays, even in static
code
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
Hi @fhueske ,
Avro array type actually is mapped to Java List type, specifically the
class **org.apache.avro.generic.GenericData.Array** extends
**java.util.AbstractList**. I tried to
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6082
We treat sequences of values as arrays in SQL and the Table API. There are
no built-in functions to handle lists. So we should return the values as an
array, and hence don't need a List type.
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
Particularly I suggest that we add LIST in org.apache.flink.table.api.Types
to support Avro array types. I can submit it in next commits if you guys think
the same.
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
Thanks @suez1224 @twalthr for reviewing. Plz see my comments and latest
commits as per your comments.
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
Thanks @suez1224 @twalthr for reviewing. Plz see my comments and latest
commits as per your comments.
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
Thans @suez1224 @twalthr for reviewing. I've moved the unit tests from
KafkaAvroTableSourceTestBase to AvroRowDeSerializationSchemaTest. As for other
comments, plz see my comments.
---
Github user suez1224 commented on the issue:
https://github.com/apache/flink/pull/6082
Thanks for the PR, @tragicjun. I will take a look in the next few days.
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
@twalthr @suez1224 would you please review on this?
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
I encountered another exception working with string type in Avro map/array,
any advice whether I should open a separate issue or just reusing this one.
---
16 matches
Mail list logo
