[GitHub] flink issue #6177: Backport of Kinesis connector changes from 1.5 to release...

2018-06-22 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6177 @tweise I've manually merged this, but forgot to add the "This closes #" message. Could you close this PR manually? Thanks! ---

[GitHub] flink issue #6177: Backport of Kinesis connector changes from 1.5 to release...

2018-06-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6177 @tweise ok, I don't really have a strong opinion on not including the other changes. Changes LGTM then, will merge this. ---

[GitHub] flink issue #6177: Backport of Kinesis connector changes from 1.5 to release...

2018-06-18 Thread tweise
Github user tweise commented on the issue: https://github.com/apache/flink/pull/6177 @tzulitai the commits in this PR (except the most recent version change) are from our 1.4.x fork and what we use in production. As discussed on the ML not even the Kinesis version number is strictly a

[GitHub] flink issue #6177: Backport of Kinesis connector changes from 1.5 to release...

2018-06-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6177 I'm not sure that we want to backport the shard-mapping hash function. IMO, that is a new feature and shouldn't go into a bugfix release. What do you think @tweise? ---