Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6188
@fhueske `MONTH`, `QUARTER`, and `YEAR` are not converted into milliseconds
but treated as interval of months. In general, Flink supports two types of
intervals one for millis and one for months. So
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6188
Hmm, I think there is still a case for `timestampAdd`. The problem are time
intervals with variable length such as `MONTH`, `QUARTER`, and `YEAR`. All of
these cannot be defined by milliseconds,
Github user xueyumusic commented on the issue:
https://github.com/apache/flink/pull/6188
@twalthr I looked around and realized that current `+` expression could
support TimeInterval (TimePoint) addition, thus the timestampAdd api is
duplicated and seems have no necessary.
Github user xueyumusic commented on the issue:
https://github.com/apache/flink/pull/6188
Thanks very much for your reivew and guidance, @walterddr @hequn8128 , I
have made some modification, please have a review when you are free, thanks!
---
Github user hequn8128 commented on the issue:
https://github.com/apache/flink/pull/6188
@xueyumusic Great that you step out to contribute to flink, I will take a
look this weekend :-)
---
Github user xueyumusic commented on the issue:
https://github.com/apache/flink/pull/6188
The first time to submit pr and could someone review it and give some
advice, thanks :)
---
Github user xueyumusic commented on the issue:
https://github.com/apache/flink/pull/6188
Travis error is "The job exceeded the maximum time limit for jobs, and has
been terminated". It seems connector module test and not related to this PR.
---
