[GitHub] flink issue #6205: [FLINK-9642]Reduce the count to deal with state during a ...

Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/6205 Hi @Aitozi , Thanks for the work here. I think we could improve a bit separation of concerns in the SharedBuffer. I am a bit afraid this class will become too complex once again. How about we s

[GitHub] flink issue #6205: [FLINK-9642]Reduce the count to deal with state during a ...

Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/6205 Hi @Aitozi , Thanks for the work here. I think we could improve a bit separation of concerns in the SharedBuffer. I am a bit afraid this class will become too complex once again. How about we s

[GitHub] flink issue #6205: [FLINK-9642]Reduce the count to deal with state during a ...

Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6205 Resolved the conflicts, please help review when you free @dawidwys . ---

[GitHub] flink issue #6205: [FLINK-9642]Reduce the count to deal with state during a ...

Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/6205 Hi, @Aitozi I think it has conflicts now. ---

[GitHub] flink issue #6205: [FLINK-9642]Reduce the count to deal with state during a ...

Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6205 Could you take a look at this PR @dawidwys ? ---

[GitHub] flink issue #6205: [FLINK-9642]Reduce the count to deal with state during a ...

Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6205 Is this look ok now? ping @sihuazhou @dawidwys ---

[GitHub] flink issue #6205: [FLINK-9642]Reduce the count to deal with state during a ...

Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6205 fixed the error that the access to state increased in `NFAStateAccessTest` by add the `isEmpty` judgment before update the state. ---

[GitHub] flink issue #6205: [FLINK-9642]Reduce the count to deal with state during a ...

Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6205 Using the `entries#putAll` in `flushCache` lead to the count in `NFAStateAccessTest` increased, I will check it locally , this travis will fail. ---

[GitHub] flink issue #6205: [FLINK-9642]Reduce the count to deal with state during a ...

Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6205 The travis error this time seems unrelated. ---

[GitHub] flink issue #6205: [FLINK-9642]Reduce the count to deal with state during a ...

Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6205 Hi @zhangminglei , thanks for your review. I only check the SharedBufferTest locally before, the error in travis means the num of state access (read and write) is less than before which is the purpos

[GitHub] flink issue #6205: [FLINK-9642]Reduce the count to deal with state during a ...

Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/6205 Hi, @Aitozi Could you please take a look on the travis error ``` Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec <<< FAILURE! - in org.apache.flink.cep.nfa