Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6231
Thanks for verification and reporting issue!
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6231
PR #6392 fixed this issue.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6231
@pnowojski thanks for giving a solution, I will try to verify it in our
inner Flink version.
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6231
True, `checkNotNull(nestedSerializers);` is useless.
Allowing nulls without enabled compile errors on violated `@Nullable`
checks (this we can not enable in Flink) always leads to some null
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6231
@pnowojski I have said it is because of the constructor :
```
CompositeTypeSerializerConfigSnapshot(TypeSerializer...
nestedSerializers)
```
used [`varargs ` in JIRA
descri
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6231
Nope, you are not quite correct. This:
```
def this() = this(null)//scala
```
translates to
```
CompositeTypeSerializerConfigSnapshot(null);
```
But because of va
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6231
hi @pnowojski I did not call the
`CompositeTypeSerializerConfigSnapshot(TypeSerializer... nestedSerializers)`
constructor explicitly, the caller is Flink itself, see
[here](https://github.com/apache
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6231
I agree with @zentol and I do not see reason for supporting nulls here.
This fix looks like hiding underlying implementation problem. Default
constructor of `CRowSerializerConfigSnapshot` could use
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6231
@zentol we really caused this exception, in our inner Flink version, we
customized flink-table and implemented stream and dim table join. I think the
default constructor is needed by deserialization.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6231
This doesn't look correct to me, the serializer should always be non-null,
and silently dropping null serializers most likely just causes other problems.
Did you actually run into this NPE whe
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6231
@pnowojski can you review this?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6231
cc @twalthr and @fhueske
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/6231
Looks good from my side @yanghua :)
---
13 matches
Mail list logo
