[GitHub] flink issue #6253: [WIP][FLINK-8094][Table API & SQL] Support other types fo...

2018-07-05 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6253 It's a good question whether to add a new class or not. Right now, extending the implementation of `ExistingField` seems like a better approach to me. Once we add a `ParsingExistingField` extractor

[GitHub] flink issue #6253: [WIP][FLINK-8094][Table API & SQL] Support other types fo...

2018-07-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/flink/pull/6253 If we would like to answer 1 as "Yes, apply the change to ExistingField.", we can rebase this PR with below branch.

[GitHub] flink issue #6253: [WIP][FLINK-8094][Table API & SQL] Support other types fo...

2018-07-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/flink/pull/6253 Seeking for some guides on this PR: 1. Maybe we could replace the implementation of ExistingField with the implementation of IsoDateStringAwareExistingField since the implementation is