Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6297
@dawidwys Please merge.
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6297
LGTM for me, Thanks for your contribution @yanghua.
@GJL would you like to have last look, or can I merge it?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6297
@dawidwys added test case, please review~
---
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/6297
Changes look good now. I think we are still missing tests for the added
behaviour. We should check:
- if yarn cli parameters are properly parsed without units
- if yarn cli parameters
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6297
cc: @dawidwys @StephanEwen
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6297
I will take a look later.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6297
@zentol can you review this?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6297
@GJL please review~
---
