Github user hequn8128 commented on the issue:
https://github.com/apache/flink/pull/6335
@zhangminglei It sounds great :-)
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/6335
Hi, @hequn8128 I will create another jira for ```new InputStreamReader```
refactor issue. What do you think ?
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/6335
Thank you very much! @hequn8128 ! I will take a look.
---
Github user hequn8128 commented on the issue:
https://github.com/apache/flink/pull/6335
Hi @zhangminglei ,
Good catch! Maybe the Reader may also need to be adapted, making `new
InputStreamReader` to `Channels.newReader`. I find a benchmark about File
InputStream and Reader
[here]
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/6335
lgtm
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/6335
Hi, @tedyu I have updated the code. Please check again. Thank you very much.
---
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/6335
From https://travis-ci.org/apache/flink/jobs/404127448 :
```
Failed tests:
BlobServerPutTest.testPutBufferFailsIncomingForJob
Expected: (an instance of java.io.IOException and excepti
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/6335
@tedyu Could you please take a look on this ? Thank you very much.
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/6335
Thanks @yanghua I will push the rest of the code then and fix the travis
error.
---
