[GitHub] flink issue #6347: [hotfix] consistency: vertexes -> vertices

2018-07-17 Thread tison1
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6347 > vertices is the correct plural, but this is another one of those cases where fixing it might cause more harm than good since it could cause merge conflicts, yet provides no functional benefit.

[GitHub] flink issue #6347: [hotfix] consistency: vertexes -> vertices

2018-07-17 Thread tison1
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6347 > vertices is the correct plural, but this is another one of those cases where fixing it might cause more harm than good since it could cause merge conflicts, yet provides no functional benefit.

[GitHub] flink issue #6347: [hotfix] consistency: vertexes -> vertices

2018-07-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6347 yes ---

[GitHub] flink issue #6347: [hotfix] consistency: vertexes -> vertices

2018-07-17 Thread tison1
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6347 > Additionally this PR makes a lot of whitespace changes that should be reverted in any case. did you mean the whitespace in comment `* ` is significant? ---

[GitHub] flink issue #6347: [hotfix] consistency: vertexes -> vertices

2018-07-17 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6347 `vertices` is the correct plural, but this is another one of those cases where fixing it might cause more harm than good since it could cause merge conflicts, yet provides no functional benefit.

[GitHub] flink issue #6347: [hotfix] consistency: vertexes -> vertices

2018-07-17 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6347 +1 from myside, it depends on @zentol or @tillrohrmann 's opinion. ---

[GitHub] flink issue #6347: [hotfix] consistency: vertexes -> vertices

2018-07-17 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6347 it seems Flink also uses "vertices", I agree your opinion. ---