Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6353
@tison1 there are too many commits, you can use `git rebase -i [commit-id]`
to squash them, then use `git push -f xxx xxx` to force update the PR.
---
Github user tison1 commented on the issue:
https://github.com/apache/flink/pull/6353
Fix unstable case, the problem is code below, that may assign `constraints`
to a long array and then to a short array, which cause out of index exception.
to solve it we could init `constraints` in
Github user tison1 commented on the issue:
https://github.com/apache/flink/pull/6353
This pr cause `HITSITCase` unstable, I retrigger ci two times to get more
info
going to fix it.
---
Github user tison1 commented on the issue:
https://github.com/apache/flink/pull/6353
I think `ExecutionGraphConstructionTest` covers it.
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6353
you are right, this PR used to improve the performance when creating ejv, I
did not make sure the exist test cases for `attachJobGraph ` covered the
exception test. if not, I suggest add some
Github user tison1 commented on the issue:
https://github.com/apache/flink/pull/6353
the existing tests verify correctness. I will take a try to give out a
benchmark report since this PR is more relevant to performance.
---
