[GitHub] flink pull request: [FLINK-1318] CsvInputFormat: Made quoted strin...

2015-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-1318] CsvInputFormat: Made quoted strin...

2015-02-04 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/265#issuecomment-72886847 Other comments on the API breaking. If not, I'd merge it... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] flink pull request: [FLINK-1318] CsvInputFormat: Made quoted strin...

2015-02-04 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/265#issuecomment-72883989 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] flink pull request: [FLINK-1318] CsvInputFormat: Made quoted strin...

2015-02-03 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/265#issuecomment-72613154 The API was just extended, but the parsing logic for strings changed (see PR description). So programs that relied on the previous way of parsing will fail now. --- If y

[GitHub] flink pull request: [FLINK-1318] CsvInputFormat: Made quoted strin...

2015-02-03 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/265#issuecomment-72612157 Looks good so far. What about this PR is API breaking? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink pull request: [FLINK-1318] CsvInputFormat: Made quoted strin...

2015-02-02 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/265#issuecomment-72501228 I added documentation. Any objections against merging this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink pull request: [FLINK-1318] CsvInputFormat: Made quoted strin...

2015-01-27 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/265#issuecomment-71760224 Yes, that's still left to do... ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] flink pull request: [FLINK-1318] CsvInputFormat: Made quoted strin...

2015-01-27 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/265#issuecomment-71631281 Looks good to me. How about adding some documentation for this feature? Maybe under http://flink.apache.org/docs/0.8/programming_guide.html#data-sources --- If your project i

[GitHub] flink pull request: [FLINK-1318] CsvInputFormat: Made quoted strin...

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/265#issuecomment-71470231 Any comments on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this