Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/265
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/265#issuecomment-72886847
Other comments on the API breaking.
If not, I'd merge it...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/265#issuecomment-72883989
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/265#issuecomment-72613154
The API was just extended, but the parsing logic for strings changed (see
PR description). So programs that relied on the previous way of parsing will
fail now.
---
If y
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/265#issuecomment-72612157
Looks good so far. What about this PR is API breaking?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/265#issuecomment-72501228
I added documentation. Any objections against merging this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/265#issuecomment-71760224
Yes, that's still left to do... ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/265#issuecomment-71631281
Looks good to me. How about adding some documentation for this feature?
Maybe under http://flink.apache.org/docs/0.8/programming_guide.html#data-sources
---
If your project i
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/265#issuecomment-71470231
Any comments on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this