[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-02-09 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/318 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-02-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/318#issuecomment-73504622 I've merged it to the 0.8 branch. I forgot to close the PR, could you do it manually? Thank you. --- If your project is set up for it, you can reply to this email an

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-02-05 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/317 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-02-05 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/317#issuecomment-73046225 Of course. Thanks for merging. On Thu, Feb 5, 2015 at 2:30 PM, Stephan Ewen wrote: > This one has been manually merged (but I made a typo in the

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-02-05 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/317#issuecomment-73045884 This one has been manually merged (but I made a typo in the "This closes #xxx" message ;-) ) @tillrohrmann Can you close the PR manually? --- If your project

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-02-04 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/317#issuecomment-72832512 +1 for removing unnecessary ExecutionGraph information before archiving. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-02-03 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/317#issuecomment-72618925 I think this is a good fix, overall. There is one issue I would really like to fix, and that is the serializability of the `Instance` class. This class is not meant to

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/317#issuecomment-72319309 Okay, I'll file a JIRA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-31 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/317#issuecomment-72319281 No I don't think that this has something to do with the shared slot release. It should be handled in a separate ticket. On Sat, Jan 31, 2015 at 11:54 AM, R

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/317#issuecomment-72313219 Hi, maybe thats a helpful datapoint for you: I have a Flink cluster started where all TaskManagers died (misconfiguration). The JobManager needs more than 200 seco

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-25 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/317#issuecomment-71423347 I am looking into this right now and testing it locally. Seems to work so far. Will try to give a vote by tomorrow... --- If your project is set up for it, you can re

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-20 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/318#discussion_r23212042 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SharedSlot.java --- @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/318#discussion_r23195339 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SharedSlot.java --- @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Soft

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-19 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/318#discussion_r23163714 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SharedSlot.java --- @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-18 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/318 [FLINK-1376] [runtime] Add proper shared slot release in case of a fatal TaskManager failure for 0.8 branch This PR introduces SharedSlots as being a special Slot type and as such being release

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-18 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/317 [FLINK-1376] [runtime] Add proper shared slot release in case of a fatal TaskManager failure This PR introduces SharedSlots as being a special Slot type and as such being released properly in c

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-18 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/309 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-18 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/309#issuecomment-70417368 Found an issue with the releasing of colocated task slots and the disposal of shared slots for colocation groups. Will open a new PR with fix and rebased code. ---

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-18 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/310#issuecomment-70417343 Found an issue with the releasing of colocated task slots and the disposal of shared slots for colocation groups. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-18 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/310 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-14 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/310 [FLINK-1376] [runtime] Add proper shared slot release in case of a fatal TaskManager failure This PR introduces SharedSlots as being a special Slot type and as such being released properly in c

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-14 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/309 [FLINK-1376] [runtime] Add proper shared slot release in case of a fatal TaskManager failure This PR introduces SharedSlots as being a special Slot type and as such being released properly in c