Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/346#issuecomment-72241355
Merged, thanks for the fix @coderxiang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/346
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/346#issuecomment-72111491
@coderxiang, ah that the tests do comparison in the after method so it is
hard to figure out which method fail. But seemed like other builds passed and I
am sure that you
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/346#issuecomment-72109489
HI @aljoscha, thanks.
If you could merge it before later tonight please do. Otherwise I could do
it later tonight if you did not have time to get to this one =)
---
Github user coderxiang commented on the pull request:
https://github.com/apache/flink/pull/346#issuecomment-72107415
@hsaputra @aljoscha I failed one check which I don't have much idea about.
Could you please retest?
---
If your project is set up for it, you can reply to this email
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/346#issuecomment-72036147
+1, can you merge it @hsaputra or should I?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
