Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/417
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/417#issuecomment-75021578
Actually, `IOManagerAsync#isProperlyShutDown` already calls the superclass
method:
```
return isShutdown.get() && readersShutDown && writersShutDown &&
super.i
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/417#issuecomment-75019114
Good comments. I address them and merge this.
The tests that fail are not related to this change (there is an instability
in the TaskManager tests currently)
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/417#issuecomment-74930615
Since the IOManager add shutdown hook to clean up the files, should
IOManagerAsync#isProperlyShutDown need to call super.isProperlyShutDown ?
---
If your project is set
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/417#discussion_r24931138
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/IOManager.java
---
@@ -52,26 +57,88 @@
/**
* Constructs a n
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/417
[FLINK-1483] IOManager puts temp files in dedicated directory and cleans up
on shutdown
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Step
