[GitHub] flink pull request: [FLINK-1484] Adds explicit disconnect message ...

2015-02-20 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/368 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1484] Adds explicit disconnect message ...

2015-02-20 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/368#issuecomment-75256160 This PR has been merged as part of PR #423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-1484] Adds explicit disconnect message ...

2015-02-20 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/368#issuecomment-75254417 @tillrohrmann and @StephanEwen worked on some other reliablity issues. Will the changes in this PR be subsumed by the upcoming changes? If not, we should merge this. :-)

[GitHub] flink pull request: [FLINK-1484] Adds explicit disconnect message ...

2015-02-09 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/368#issuecomment-73478622 My bad, there is a ticket already. Can you squash the commits then and add the ticket tag? Otherwise, good to merge! --- If your project is set up for it,

[GitHub] flink pull request: [FLINK-1484] Adds explicit disconnect message ...

2015-02-09 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/368#issuecomment-73478074 Looks good. Since this is a behavior change, can you file a ticket for this, Till? --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-1484] Adds explicit disconnect message ...

2015-02-09 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/368#issuecomment-73479833 Yes, I'll do it. On Mon, Feb 9, 2015 at 10:23 AM, Stephan Ewen notificati...@github.com wrote: My bad, there is a ticket already. Can you squash

[GitHub] flink pull request: [FLINK-1484] Adds explicit disconnect message ...

2015-02-06 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/368#discussion_r24227786 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -125,6 +126,10 @@ Actor with ActorLogMessages with

[GitHub] flink pull request: [FLINK-1484] Adds explicit disconnect message ...

2015-02-05 Thread hsaputra
Github user hsaputra commented on a diff in the pull request: https://github.com/apache/flink/pull/368#discussion_r24220454 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -125,6 +126,10 @@ Actor with ActorLogMessages with

[GitHub] flink pull request: [FLINK-1484] Adds explicit disconnect message ...

2015-02-05 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/368 [FLINK-1484] Adds explicit disconnect message for TaskManagers In case of a JobManager restart, which can be caused by an uncaught exception, all connected TaskManager are notified by a