[GitHub] flink pull request: [FLINK-1515]Splitted runVertexCentricIteration...

2015-02-23 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/402#issuecomment-75588051 Thank you @tillrohrmann! Then, I'll go ahead and merge this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-1515]Splitted runVertexCentricIteration...

2015-02-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/402 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-1515]Splitted runVertexCentricIteration...

2015-02-20 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/402#issuecomment-75220973 Hi, if no more comments, I'd like to merge this. There is a failing check in Travis (not related to this PR): ``` Tests in error:

[GitHub] flink pull request: [FLINK-1515]Splitted runVertexCentricIteration...

2015-02-20 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/402#issuecomment-75279454 I'm currently working on fixing this problem. You can ignore it for the moment. On Fri, Feb 20, 2015 at 11:58 AM, Vasia Kalavri notificati...@github.com

[GitHub] flink pull request: [FLINK-1515]Splitted runVertexCentricIteration...

2015-02-19 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/402#issuecomment-75029446 Oh, one minor thing.. Could you prefix your commits with [FLINK-1515] [gelly] ? Thanks! --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-1515]Splitted runVertexCentricIteration...

2015-02-19 Thread cebe
Github user cebe commented on the pull request: https://github.com/apache/flink/pull/402#issuecomment-75051739 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink pull request: [FLINK-1515]Splitted runVertexCentricIteration...

2015-02-17 Thread martinkiefer
Github user martinkiefer commented on the pull request: https://github.com/apache/flink/pull/402#issuecomment-74660459 I could change `PageRank` to read the number of vertices by broadcasting the result of `numberofVertices()` instead of providing it in the constructor of the

[GitHub] flink pull request: [FLINK-1515]Splitted runVertexCentricIteration...

2015-02-16 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/402#issuecomment-74525590 Hi @martinkiefer! Thanks a lot for this pull request! The change looks good :) I was only thinking that it would be nice to have an example that demonstrates

[GitHub] flink pull request: [FLINK-1515]Splitted runVertexCentricIteration...

2015-02-15 Thread martinkiefer
GitHub user martinkiefer opened a pull request: https://github.com/apache/flink/pull/402 [FLINK-1515]Splitted runVertexCentricIteration into createVertexCentricIteration and runVertexCentricIteration I changed the process for running a vertex-centric iteration in Gelly into a